Feat: Input, Dropdown components #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEGUMMY1
requested review from
waterkail,
jimin0209,
ssumai-kr and
GoldenHamsterK
13akstjq
reviewed
Apr 11, 2024
| className={styles.option} | ||
| onClick={() => handleOptionClick(option.value)} | ||
| > | ||
| {option.label} |
There was a problem hiding this comment.
li는 클릭 가능한 요소가 아니라서 onClick을 넣는 것은 접근성 위배입니다. li태그 하위에 button태그를 추가해서 onClick을 추가하는 방식으로 사용해주세요!
| className={styles.dropdown_icon} | ||
| width={15} | ||
| height={15} | ||
| alt="dropdown icon" |
| <div className={styles.dropdown} onClick={toggleDropdown}> | ||
| <span>{value}</span> | ||
| <img | ||
| src={isOpen ? topIcon : downIcon} |
There was a problem hiding this comment.
클래스명에 -open 클래스를 추가하고 css로 rotate를 하면 이미지 한개로만 작업할 수 있겠죠?
|
|
||
| return ( | ||
| <div className={styles.dropdown_wrapper}> | ||
| <div className={styles.dropdown} onClick={toggleDropdown}> |
There was a problem hiding this comment.
여기서도 div에 onClick을 사용하면 접근성 위배입니다!
div에서 onClick을 사용해야한다면 role="button" 추가 및 onKeydown , tabIndex 추가해주어야 합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
📸스크린샷
💬리뷰 요구사항